Conversation
|
@incubus-ank Would it be more performant to move the allocation into the constructor and free into the destructor of |
Yes, I think it's a good idea. I'm not a pro at working with CUDA. Should I define/remove copy and move constructors to avoid funny situations and create a better interface? |
|
I would say no because this class can only be created with the factory method Ideally I would suggest using a |
…o avoid memory reallocation
…sync_memory_leak Add missing cudaFree opencv#3999 I found missing memory cudaFree in cv::cuda::FAST_Impl::detectAsync() I created an issue, but did not receive a response. opencv#3994 ### Pull Request Readiness Checklist - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [x] There is a reference to the original bug report and related work - [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [x] The feature is well documented and sample code can be built with the project CMake
3 participants
I found missing memory cudaFree in cv::cuda::FAST_Impl::detectAsync()
I created an issue, but did not receive a response.
#3994
Pull Request Readiness Checklist
Patch to opencv_extra has the same branch name.